On Tue, 2015-03-24 at 13:10 +0100, Julian Sedding wrote: > Hi Robert > > I was wondering whether these changes are at the right place. There is > a sling.properties file in launchpad/testing, which still has the old > run mode definition. Sightly testing may also be affected. > > Note that I didn't run any tests, so I may be completely wrong. > > $ find . -name "*.properties" | xargs grep sling.run.mode.install.options > ./contrib/scripting/sightly/testing/src/test/config/sling.properties:sling.run.mode.install.options=jackrabbit,oak > ./launchpad/builder/src/main/sling/common.properties:sling.run.mode.install.options=jackrabbit,oak|oak_tar,oak_mongo > ./launchpad/testing/src/test/config/sling.properties:sling.run.mode.install.options=jackrabbit,oak
Ah, you're right. This shows that I still need to dig some more into runmodes :-) I've changed the launchpad/testing to mimic the launchpad/builder setup and reverted the Jenkins changes. I did nothing for the Sightly launchpad since it is based on the 7 bundleList, and that one only has the jackrabbit and oak bundle run modes. Cheers, Robert > > Regards > Julian > > > On Mon, Mar 23, 2015 at 9:10 PM, <[email protected]> wrote: > > Author: rombert > > Date: Mon Mar 23 20:10:23 2015 > > New Revision: 1668712 > > > > URL: http://svn.apache.org/r1668712 > > Log: > > SLING-4050 - Make it easier to run launchpad on Oak/Mongo > > > > Use oak,oak_tar as the run mode for the testing launchpad. It would seem > > that the oak_tar,oak_mongo mandatory run modes are not being evaluated, > > so 'fix' this issue in the testing launchpad. > > > > Modified: > > sling/trunk/launchpad/testing/pom.xml > > > > Modified: sling/trunk/launchpad/testing/pom.xml > > URL: > > http://svn.apache.org/viewvc/sling/trunk/launchpad/testing/pom.xml?rev=1668712&r1=1668711&r2=1668712&view=diff > > ============================================================================== > > --- sling/trunk/launchpad/testing/pom.xml (original) > > +++ sling/trunk/launchpad/testing/pom.xml Mon Mar 23 20:10:23 2015 > > @@ -312,7 +312,7 @@ > > <activeByDefault>true</activeByDefault> > > <property> > > <name>sling.run.modes</name> > > - <value>!oak</value> > > + <value>!oak,oak_tar</value> > > </property> > > </activation> > > <properties> > > @@ -324,7 +324,7 @@ > > <activation> > > <property> > > <name>sling.run.modes</name> > > - <value>oak</value> > > + <value>oak,oak_tar</value> > > </property> > > </activation> > > <properties> > > > >
