[
https://issues.apache.org/jira/browse/SLING-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390046#comment-14390046
]
Carsten Ziegeler edited comment on SLING-4558 at 4/1/15 6:31 AM:
-----------------------------------------------------------------
While I see the reason behind this, I don't like the special casing. Why does
it only handle service user configs and not others like log configurations etc?
All of them have potentially long names. And hard coding such a mapping in the
installer does not look right to me.
So we can either come up with a configuration of mappings or with configuration
of rules - while the latter is more complicated.
We shouldn't also hide the difference between component and factory
configurations, and just "serviceuser" looks like a component config while it
is a factory config.
Finally, if we do this, property file names should be supported as well.
was (Author: cziegeler):
While I see the reason behind this, I don't like the special casing? Why does
it only handle service user configs and not others like log configurations etc.
All of them have potentially long names. And hard coding such a mapping in the
installer does not look right to me.
So we can either come up with a configuration of mappings or with configuration
of rules - while the latter is more complicated.
We shouldn't also hide the difference between component and factory
configurations, and just "serviceuser" looks like a component config while it
is a factory config.
Finally, if we do this, property file names should be supported as well.
> Simpler serviceuser config for service user mappings
> ----------------------------------------------------
>
> Key: SLING-4558
> URL: https://issues.apache.org/jira/browse/SLING-4558
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Reporter: Alexander Klimetschek
> Attachments: SLING-4558.patch
>
>
> For a service user configuration (amendment), one has to currently remember a
> weird long PID:
> {{org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl.amended}}
> plus making sure it has a unique ID by appending {{-something}}, which
> confuses people as to whether that "something" must correspond to a bundle or
> service name (not necessary) or they come up with these long names:
> {{org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl.amended-org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl.amended.something.xml}}
> which then create too long paths for some cases (git checkouts under windows
> or jcr repository limitations).
> A simple {{serviceuser}} config node name would be better.
> For reference, the target service is
> [MappingConfigAmendment|https://github.com/apache/sling/blob/trunk/bundles/extensions/serviceusermapper/src/main/java/org/apache/sling/serviceusermapping/impl/MappingConfigAmendment.java]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
