[
https://issues.apache.org/jira/browse/SLING-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391173#comment-14391173
]
ASF GitHub Bot commented on SLING-4562:
---------------------------------------
GitHub user vladbailescu opened a pull request:
https://github.com/apache/sling/pull/82
SLING-4562 - Sightly: Allow passing of custom options to the I18n extension
- Changed the I18nFilter to pass all options to the extension call
- Changed the I18nRuntimeExtension to extract locale and hint for the
options map
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vladbailescu/sling
SLING-4562_custom_i18n_options
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/sling/pull/82.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #82
----
commit 107f631fd21cfef4a47537ed66d06694e8e8bdc3
Author: vladbailescu <[email protected]>
Date: 2015-04-01T18:36:10Z
SLING-4562 - Sightly: Allow passing of custom options to the I18n extension
- Changed the I18nFilter to pass all options to the extension call
- Changed the I18nRuntimeExtension to extract locale and hint for the
options map
----
> Sightly: Allow passing of custom options to the I18n extension
> --------------------------------------------------------------
>
> Key: SLING-4562
> URL: https://issues.apache.org/jira/browse/SLING-4562
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
> Affects Versions: Scripting Sightly Engine 1.0.0
> Reporter: Vlad Bailescu
> Priority: Minor
> Fix For: Scripting Sightly JS Use Provider 1.0.2
>
>
> The current [Sightly
> specification|https://github.com/Adobe-Marketing-Cloud/sightly-spec/blob/master/SPECIFICATION.md#123-i18n]
> only lists {{locale}} and {{hint}} as possible options for the I18n
> extensions and these are passed as parameters to the {{call(..)}} method.
> However, the [initial Sightly
> docs|http://docs.adobe.com/docs/en/aem/6-0/develop/sightly.html#Internationalization]
> are referencing another option ({{source}}) that Adobe is using in AEM.
> We should pass a map containing option names and values to the extension
> {{call(..)}}, like we do in the resource inclusion extension, so that vendors
> such as Adobe can use custom options when extending this functionality.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
