Hi Joel

In my experience more often than not lazy loading in rendering
components is very much desirable. So my +1 for that.

You say that most often MergedValueMap is created based on a single
ValueMap. I haven't looked at the code just now, but I'm wondering if
creation could happen in a factory method. This would allow passing
back the original map in case no merging is necessary?

Regards
Julian

On Tue, Apr 7, 2015 at 5:46 PM, Joel Richard <[email protected]> wrote:
> Hi,
>
> About 4% of the rendering time is spent in MergedValueMap in
> ValueMapDecorator.putAll because the JcrPropertyMap has to be read fully
> before it can be added. Therefore, I would suggest to lazily read the
> properties in get(key). What do you think?
>
> By the way, in my case 202 of 252 times the MergedValueMap is created only
> with a single value map. Is this expected? At least in these cases it does
> not make any sense to read all properties.
>
> - Joel

Reply via email to