On Tuesday 07 April 2015 08:11:31 Carsten Ziegeler wrote: > Am 05.04.15 um 21:49 schrieb Oliver Lietz: > > On Wednesday 01 April 2015 15:43:00 Carsten Ziegeler wrote: > >> Hi, > >> > >> We solved 3 issues for this release > >> https://issues.apache.org/jira/browse/SLING/fixforversion/12329265 > > > > This looks strange to me: > > if (metadata != null) { // test does not implement metadata > > This should be removed and the test should be fixed (SLING-4580). > However I don't > think this blocks the release. metadata is always not null. > > > Shouldn't we mock metadata in test instead? > > > > And we (re)add a Jackrabbit dependency with this release. > > Args! This is definitely a regression. I've created SLING-4579 to fix this. > However, I don't think this blocks the release vote for 2.4.0. We can > easily fix it and then release 2.4.2 > > WDYT?
You've already fixed both issues - shouldn't we just go for 2.4.2 quickly and drop 2.4.0? O. > Regards > Carsten
