[ 
https://issues.apache.org/jira/browse/SLING-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486401#comment-14486401
 ] 

Alexander Klimetschek commented on SLING-4579:
----------------------------------------------

Just looked at the change: The node type check is wrong as it does not support 
node type inheritance. Of course, it's rather unlikely that someone would have 
say a node type my:CustomMessage which inherits from sling:Message, but then it 
would be better if we don't check the type and just take the presence of the 
sling:message property indicator.

And I don't see the regression - we had the JCR dependency in the pom 
(non-test) in there before without problems.

> Regression introduced by SLING-4512 : JCR API used in i18n implementation
> -------------------------------------------------------------------------
>
>                 Key: SLING-4579
>                 URL: https://issues.apache.org/jira/browse/SLING-4579
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>            Priority: Critical
>             Fix For: i18n 2.4.2
>
>
> The i18n module should be free from JCR API usage to allow it to run on any 
> resources providing i18n messages. SLING-4512 unfortunately removed this 
> functionality by directly using JCR API



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to