[ 
https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494267#comment-14494267
 ] 

Joel Richard commented on SLING-4544:
-------------------------------------

[~fmeschbe], [~jsedding], I have just had a closer look at where the time is 
lost and about 40% of the formatting time is spent in toString methods. About 
50% of the formatting time can be saved with a faster MessageFormat 
implementation (which isn't based on NumberFormat and Format) or by storing the 
arguments/strings in the TrackingEntry.

> Performance: MessageFormat shouldn't be used for logging in 
> SlingRequestProgressTracker
> ---------------------------------------------------------------------------------------
>
>                 Key: SLING-4544
>                 URL: https://issues.apache.org/jira/browse/SLING-4544
>             Project: Sling
>          Issue Type: Improvement
>          Components: Engine
>    Affects Versions: Engine 2.4.0
>            Reporter: Joel Richard
>              Labels: performance
>         Attachments: SLING-4544.patch, Screen Shot 2015-03-25 at 10.42.05.png
>
>
> I am profiling an application where 1-5% of the rendering time is spent in 
> MessageFormat.format for SlingRequestProgressTracker.log (see attached 
> screenshot). Since the advanced capabilities of MessageFormat are not 
> required here, it should be rather easy to implement a utility which supports 
> \{x} as well but is much faster.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to