Hi Dan, On Fri, Apr 17, 2015 at 11:05 PM, Daniel Klco <[email protected]> wrote: > ...https://github.com/apache/sling/pull/86...
Interesting, I think this is definitely useful! > ... - Does the integration test logic make sense?.. The tests probably fail as you're not doing the additional setup that launchpad/testing does: installing the test services bundles and preparing a few additional configs. Maybe you could just use that? Use mvn launchpad:run under launchpad/testing to start the Sling instance, and then add the bundles under test to it? Or maybe just add an options file to that module so that it loads the staged bundles after you have built them? > ... - Does it make more sense to combine this and the existing check staged > release script?... I'd rather leave them separate as this takes much more time and we might not want to run it on every release check. >... - Any comments or suggestions?... Running this on Jenkins would be fantastic ;-) Maybe based on a text file in svn that lists which staged modules need to be tested, and the Jenkins job picks that up. -Bertrand
