[
https://issues.apache.org/jira/browse/SLING-4568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Richard updated SLING-4568:
--------------------------------
Attachment: SLING-4568_skip-underlying.patch
[~cziegeler], I have created a new patch (SLING-4568_skip-underlying.patch)
which does not contain the exclude search path configuration and does skip the
ParentHidingHandler also for listChildren and CRUDMergingResourceProvider.
Sorry for the detour, I should have seen before that there are other
ParentHidingHandler usages which should be adjusted as well.
I had to adjust the code in CRUDMergingResourceProvider#getAllResources a
little bit further to prevent that the parent is not read unnecessarily. I even
wanted to create a comment addResourceToHolder method, but this isn't possible
right now because they use different unrelated resource holder classes.
> Performance: MergingResourceProvider.ParentHidingHandler adds about 30pp
> rendering overhead
> -------------------------------------------------------------------------------------------
>
> Key: SLING-4568
> URL: https://issues.apache.org/jira/browse/SLING-4568
> Project: Sling
> Issue Type: Bug
> Components: ResourceResolver
> Affects Versions: Resource Merger 1.2.8
> Reporter: Joel Richard
> Assignee: Carsten Ziegeler
> Labels: performance
> Fix For: Resource Merger 1.2.10
>
> Attachments: SLING-4568_exclude_search_paths.patch,
> SLING-4568_experimental_cache.patch, SLING-4568_skip-underlying.patch
>
>
> When I was analysing all read properties, I noticed a recurring pattern with
> sling:hideChildren and jcr:primaryType and that more than 40% of the read
> properties are sling:hideChildren. I figured out that sling:hideChildren is
> read for all parents in MergingResourceProvider.ParentHidingHandler and that
> the requests are processed 30-35pp faster just by commenting out the
> constructor code.
> Apache Benchmark results with normal ParentHidingHandler:
> {quote}
> 50% 272
> 66% 276
> 75% 278
> 80% 281
> 90% 289
> 95% 301
> 98% 493
> 99% 497
> {quote}
> Results with commented out ParentHidingHandler constructor:
> {quote}
> 50% 185
> 66% 188
> 75% 191
> 80% 194
> 90% 202
> 95% 210
> 98% 333
> 99% 338
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
