[
https://issues.apache.org/jira/browse/SLING-4672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520114#comment-14520114
]
ASF GitHub Bot commented on SLING-4672:
---------------------------------------
GitHub user kevin-roll opened a pull request:
https://github.com/apache/sling/pull/88
SLING-4672
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevin-roll/sling SLING-4672
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/sling/pull/88.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #88
----
commit c11a44ba40e5dcecb2e6a1cb649562377ecea084
Author: Kevin A. Roll <[email protected]>
Date: 2015-04-29T18:05:27Z
SLING-4672 : Default port is read from property file rather than always
coming from the command line.
commit 62ceef0ea7d6cd58e8aae526108269f97179232d
Author: Kevin A. Roll <[email protected]>
Date: 2015-04-29T18:10:02Z
SLING-4672 : Fixed incorrect log statement.
----
> Set port via property file when launching standalone
> ----------------------------------------------------
>
> Key: SLING-4672
> URL: https://issues.apache.org/jira/browse/SLING-4672
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
> Affects Versions: Launchpad Base 2.5.0
> Reporter: Kevin A. Roll
> Priority: Minor
>
> Currently it is not possible to launch the Sling standalone jar and configure
> the port via the sling.properties/sling_install.properties file. This is
> because MainDelegate always puts a value in the property map for the port and
> then overrides Sling.loadConfigProperties(), passing this value.
> Carsten suggested on the mailing list:
> "This is a little bit tricky, in general it should be possible to just rely
> on sling properties. The general mechanism is that you can override values of
> sling properties when launching, e.g. by specifying the -D option.
> Unfortunately, the default port is set by the MainDelegate in the same way.
> Therefore the underlying mechanism which processes sling properties thinks
> that this is an override and overwrites the sling properties setting. If I
> see it correctly, the port is the only property that has this special
> handling. I guess we could solve this by defining the default port in the
> sling.properties file from base and removing the special handling in the
> launchpad code."
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
