[
https://issues.apache.org/jira/browse/SLING-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528158#comment-14528158
]
Bertrand Delacretaz commented on SLING-4416:
--------------------------------------------
Ah sorry I missed that, I agree that we should keep the same result type for
backwards compatibility, and a failing health check does sound critical to me.
For now I've changed back to CRITICAL in revision 1677756 - we can discuss on
our dev list if people disagree.
> Improve HC Message/Status if a HC implementation throws an exception
> --------------------------------------------------------------------
>
> Key: SLING-4416
> URL: https://issues.apache.org/jira/browse/SLING-4416
> Project: Sling
> Issue Type: Improvement
> Components: Health Check
> Affects Versions: Health Check Core 1.1.2
> Reporter: Georg Henzler
> Assignee: Bertrand Delacretaz
> Fix For: Health Check Core 1.2.4
>
> Attachments: SLING-4416-Improved-Exception-Handling.patch
>
>
> At the moment, if a HC throws an exception, both status and and message are
> not ideal:
> {code}
> CRITICAL Exception during execution of
> org.apache.sling.hc.core.impl.executor.HealthCheckFuture$1@688ec41b:
> java.lang.NullPointerException
> {code}
> The attached patch changes the behaviour to the following:
> {code}
> HEALTH_CHECK_ERROR Exception during execution of 'My HC Name':
> java.lang.NullPointerException
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
