+1, thanks for the clarification. On Tue, May 26, 2015 at 11:29 AM, Stefan Seifert <[email protected]> wrote:
> no, they are not indented to be deployed as bundles; and will never work > deployed because the access some classes from other sling bundles that are > not exported but needed for the mocking. > > but it is useful to use the maven bundle plugin baseline check for them as > well to ensure API compatibility for unit tests. that’s the only reason for > the bundle project type. > > stefan > > >-----Original Message----- > >From: Daniel Klco [mailto:[email protected]] > >Sent: Tuesday, May 26, 2015 5:14 PM > >To: [email protected] > >Subject: Re: [VOTE] Release Apache Sling Testing OSGi Mock 1.3.0, JCR Mock > >1.1.6, ResourceResolver Mock 1.1.6, Sling Mock 1.3.0, Logging Mock 1.0.0 > > > >Are OSGI Mock, Sling Mock or JCR Mock meant to be deployed as bundles? > >Their packaging is bundle, but in a vanilla Sling Launchpad they are > >missing some dependencies including: > > > > - com.google.common > > - org.apache.commons.lang3 > > - org.apache.sling.jcr.resource.internal > > - org.apache.sling.models.impl > > - org.apache.sling.resourceresolver.impl > > - org.apache.sling.serviceusermapping.impl > > - org.apache.sling.testing.resourceresolver > > - org.junit > > - org.reflections > > > >I'm assuming that the intent is not for these to be deployed as bundles > but > >be run in jUnit tests, if so is there a reason for them to have the bundle > >packaging? > > > >-Dan > > > >On Tue, May 26, 2015 at 10:50 AM, Stefan Egli <[email protected]> > wrote: > > > >> +1, > >> > >> Cheers, > >> Stefan > >> > >> On 5/22/15 10:12 PM, "Stefan Seifert" <[email protected]> wrote: > >> > >> >Hi, > >> > > >> >We solved issues in this releases: > >> > > >> >Testing OSGi Mock 1.3.0 > >> >https://issues.apache.org/jira/browse/SLING/fixforversion/12329488 > >> > > >> >Testing JCR Mock 1.1.6 > >> >https://issues.apache.org/jira/browse/SLING/fixforversion/12329489 > >> > > >> >Testing ResourceResolver Mock 1.1.6 > >> >https://issues.apache.org/jira/browse/SLING/fixforversion/12329490 > >> > > >> >Testing Sling Mock 1.3.0 > >> >https://issues.apache.org/jira/browse/SLING/fixforversion/12329491 > >> > > >> >Testing Logging Mock 1.0.0 > >> >https://issues.apache.org/jira/browse/SLING/fixforversion/12332402 > >> > > >> > > >> >Staging repository: > >> > > https://repository.apache.org/content/repositories/orgapachesling-1251/ > >> > > >> >You can use this UNIX script to download the release and verify the > >> >signatures: > >> >http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh > >> > > >> >Usage: > >> >sh check_staged_release.sh 1251 /tmp/sling-staging > >> > > >> >Please vote to approve this release: > >> > > >> > [ ] +1 Approve the release > >> > [ ] 0 Don't care > >> > [ ] -1 Don't release, because ... > >> > > >> >This majority vote is open for at least 72 hours. > >> > > >> > > >> >stefan > >> > >> > >> >
