[
https://issues.apache.org/jira/browse/SLING-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14559256#comment-14559256
]
Bertrand Delacretaz commented on SLING-4735:
--------------------------------------------
Thanks for this! Here are my comments after reviewing your patch:
No need for the maven-scm-client dependency IMO, org.mockito/mockito-core/1.9.0
works for me.
The WebConsolePrinterTest and QuartzSchedulerTest are fragile as they check
output strings for exact matches. I would much prefer using regular expressions
for that, to test only subsets of those strings (console output and exception
messages). For exceptions I'm not sure if we want to test the messages, maybe
just check that they contain the critical info (like the filename for a "file
not found" message) but without checking the details.
If possible, avoid snapshots in dependencies.
Apart from that I think those tests do add value and I'd be ready to commit
them - if you do those changes soon I'll wait for that,.
> New tests for commons.scheduler module
> --------------------------------------
>
> Key: SLING-4735
> URL: https://issues.apache.org/jira/browse/SLING-4735
> Project: Sling
> Issue Type: Test
> Components: Commons
> Reporter: Petr Shypila
> Priority: Minor
> Labels: gsoc2015
> Attachments: week0-commons-scheduler-tests.patch
>
>
> In scope of this issue I should cover commons.scheduler module with unit and
> integration tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
