Agraj Mangal created SLING-4753:
-----------------------------------

             Summary: Commit the Resource Resolver before passing it to Tenant 
Customizers for setting up their own customizations
                 Key: SLING-4753
                 URL: https://issues.apache.org/jira/browse/SLING-4753
             Project: Sling
          Issue Type: Bug
          Components: Extensions
    Affects Versions: Tenant 1.0.4
            Reporter: Agraj Mangal


We should commit the Resource Resolver after creating the Tenant Resource and 
before passing it on to the Tenant Customizers. 

One possible issue is that one of the Tenant Customizers calls some APIs like 
PageManager##createPage that does a session.refresh() and rollbacks all the 
un-committed changes on the resolver so far. That could also include the tenant 
resource itself. 

Ideally the TenantCustomizers should not call commit on the resolver and let 
TenantProvider commit the changes, but it would be a good protection against 
all such cases where we could prevent the tenant resource from getting modified 
if the TenantCustomizer failed and tried to refresh the session.

We are experiencing this issue in https://jira.corp.adobe.com/browse/MAC-25410 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to