Hello Bertrand, Just want to notify that I have updated my previous report. First for all I have attached a new patch with new unit tests(But I think you should apply previous one as well). You can find an updated patch file on JIRA ticket and wiki page. Last changes are also on my GitHub repo: https://github.com/PetrShypila/sling Should I create a new pull request with these changes? As I wrote in my PPP report I'm going start to write new tests for commons.threads module. What do you think about that?
Best regards, Petr 2015-05-24 22:02 GMT+03:00 Petr Shypila <[email protected]>: > Hello Bertrand, > > At this time I have improved module code coverage up to 50%. Unfortunately > it looks like sometimes I need more time to understand what the code does > than to write tests for it. > I started from pretty simple classes. Most of tests for them just are just > testing references to objects after they were passed into methods(Does it > make sense to spend a time on simple tests like these or it's redundant?). > I have created a JIRA issue for this module: SLING-4735. > And I also have updated a Confluence page. Please also take a look. > > Best regards, > -Petr > > 2015-05-18 14:59 GMT+03:00 Bertrand Delacretaz <[email protected]>: > >> On Mon, May 18, 2015 at 1:55 PM, Petr Shypila <[email protected]> >> wrote: >> > ...I'm going start to code today. So at the end of the week I will show >> you >> > some completed work... >> >> Ok great! Release early, release often, it doesn't have to be finished >> before you show it to us! >> >> -Bertrand >> > >
