[
https://issues.apache.org/jira/browse/SLING-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562564#comment-14562564
]
Bertrand Delacretaz edited comment on SLING-4757 at 5/28/15 3:00 PM:
---------------------------------------------------------------------
We should also check that the jacoco report takes the integration tests into
account. I think it should be the case but we need to check it.
_Update: see SLING-4760 about this_.
was (Author: bdelacretaz):
We should also check that the jacoco report takes the integration tests into
account. I think it should be the case but we need to check it.
> Improve test coverage and add integration tests to the contentdetection module
> ------------------------------------------------------------------------------
>
> Key: SLING-4757
> URL: https://issues.apache.org/jira/browse/SLING-4757
> Project: Sling
> Issue Type: Improvement
> Components: Commons
> Reporter: Bertrand Delacretaz
> Assignee: Petr Shypila
>
> The new SLING-4694 contentdetection module has reasonable test coverage but
> there are some gaps, and it's also missing some integration tests to verify
> that the services provided by the bundle are correctly made available in an
> OSGI environment.
> I'll take this opportunity to ask our GSoC student [~petr.shypila] to expand
> these tests, as that's a good example of what we're trying to do with his
> tests improvement project.
> So [~petr.shypila] here's your "mission" ;-)
> Buliding bundles/commons/contentdetection with with -Pjacoco-report and
> looking at target/site/jacoco/index.html shows that a few things are not
> tested. The first step is to add the missing unit tests to improve that,
> maybe provide a first patch with just that.
> Then, we'd like to add integration tests that start this bundle in an OSGi
> environment and verify that the ContentAwareMimeTypeService and
> FileNameExtractor services are available and work. No need to duplicate the
> unit tests, just verify that the services are here and work in a simple case.
> The best way to do this is probably with Pax Exam, the
> ResourceBundleProviderIT. is a good example of that and there are other
> examples in our codebase if you search for *IT.java files that contain
> "pax.exam".
> As usual, try to minimize changes to the pom (except for what's directly
> related to testing) and to non-test code.
> Feel free to ask if you have any questions of course, either here for minor
> ones or on the dev list for larger discussions.
> [1]
> https://svn.apache.org/repos/asf/sling/trunk/bundles/extensions/i18n/src/test/java/org/apache/sling/i18n/it/ResourceBundleProviderIT.java
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
