[ 
https://issues.apache.org/jira/browse/SLING-4541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14579101#comment-14579101
 ] 

Robert Munteanu commented on SLING-4541:
----------------------------------------

[~bdelacretaz] - I've committed my changes in http://svn.apache.org/r1684450 , 
I needed a basic implementation of SLING-4781 for that. Some notes:

- I too had to bump the jackrabbit-api version, but dramatically this time, up 
to 2.10.1 . This is a requirement of the Sling Mocks as they embed recent 
version of Oak ( and Jackrabbit ) . This needs to be clarified before 
considering the change 'done'
- The test is pretty much an integration test, verifying that the entry point ( 
{{BundleContentLoader}} ) works as expected when configured correctly. As such, 
it covers quite a bit more than the {{DefaultContentCreator}} class
- One test is ignored {{loadXmlAsIs}} as I need to find a proper way to 
unregister the {{XmlReader}} just for that test, but it shows the kind of extra 
testing that can be performed

> Provide an extensive test suite for the JCR content loader
> ----------------------------------------------------------
>
>                 Key: SLING-4541
>                 URL: https://issues.apache.org/jira/browse/SLING-4541
>             Project: Sling
>          Issue Type: Bug
>          Components: JCR
>    Affects Versions: JCR ContentLoader 2.1.10
>            Reporter: Radu Cotescu
>            Assignee: Petr Shypila
>             Fix For: JCR ContentLoader 2.2.0
>
>         Attachments: week2-part1-pathentry.patch, 
> week2-part2-defaultcontentcreator.patch, week2-part3-single-jcrmock-test.patch
>
>
> The JCR content loader is a sensible bundle. An extensive IT suite should be 
> written to make sure that code changes don't affect core functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to