[
https://issues.apache.org/jira/browse/SLING-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14582044#comment-14582044
]
Konrad Windszus edited comment on SLING-4779 at 6/11/15 3:12 PM:
-----------------------------------------------------------------
Making it even smaller is really dangerous. Because then you would depend on
other classes from the commons-osgi bundle. That would force a dependency of
models-impl to the commons-osgi bundle. And then the SortingServiceTracker
might be provided through both classloaders: the commons-osgi bundle
classloader and through the embedded classloader. Since I don't want to debug
such class loading issues I guess it is just safer to completely embed the
necessary classes from commons-osgi and get rid of the import-package statement
completely! Then you don't run into any conflicts, because then the
commons-osgi classloader is not used at all.
was (Author: kwin):
Making it even smaller is really dangerous. Because then you would depend on
other classes from the commons-osgi bundle. That would force a dependency
models-impl to the commons-osgi bundle. And then the SortingServiceTracker
might be provided through both classloaders: the commons-osgi bundle
classloader and through the embedded classloader. Since I don't want to debug
such class loading issues I guess it is just safer to completely embed the
necessary classes from commons-osgi and get rid of the import-package statement
completely! Then you don't run into any conflicts, because then the
commons-osgi classloader is not used at all.
> Rely on RankedServices for Sling Models
> ---------------------------------------
>
> Key: SLING-4779
> URL: https://issues.apache.org/jira/browse/SLING-4779
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Fix For: Sling Models Impl 1.2.0
>
> Attachments: SLING-4779-v1.diff
>
>
> To prevent issues like SLING-4195 and SLING-4192 and to make the code cleaner
> and leaner we should switch to the helper class {{ServiceRanking}} from
> SLING-4521.
> For that we must increase the dependency towards {{commons-osgi}} to version
> 2.3.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
