[ 
https://issues.apache.org/jira/browse/SLING-4541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Petr Shypila updated SLING-4541:
--------------------------------
    Attachment: week3.patch

Hello,

Thank you for the information about RepositoryProvider. Yes, now it's much more 
easier.

I have covered with tests these methods of DefaultContentCreator:
DefaultContentCreator#createNode(String name, String primaryNodeType, String[] 
mixinNodeTypes)
DefaultContentCreator#createProperty(String name, int propertyType, String[] 
values)
DefaultContentCreator#finishNode() which actually just runs private 
resolveReferences(Node node)

I have also deleted RunWith(JMock.class) annotation because it's breaks work of 
ExpectedException rule and I also added junit-addons dependency to use 
PrivateAccessor.

-Petr

> Provide an extensive test suite for the JCR content loader
> ----------------------------------------------------------
>
>                 Key: SLING-4541
>                 URL: https://issues.apache.org/jira/browse/SLING-4541
>             Project: Sling
>          Issue Type: Bug
>          Components: JCR
>    Affects Versions: JCR ContentLoader 2.1.10
>            Reporter: Radu Cotescu
>            Assignee: Petr Shypila
>             Fix For: JCR ContentLoader 2.2.0
>
>         Attachments: week2-part1-pathentry.patch, 
> week2-part2-defaultcontentcreator.patch, 
> week2-part3-single-jcrmock-test.patch, week3.patch
>
>
> The JCR content loader is a sensible bundle. An extensive IT suite should be 
> written to make sure that code changes don't affect core functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to