[ 
https://issues.apache.org/jira/browse/SLING-4804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585847#comment-14585847
 ] 

Tomek Rękawek commented on SLING-4804:
--------------------------------------

I updated the patch, so now it decodes the URI before extracting the semicolon.

I also took a look on the Request class in Jetty \[1] and there is this HttpURI 
object that already contains parsed parameter \[2]. However, they are part of 
the Jetty internal API, so we probably can't reference them in the Sling 
engine. On the other hand, copying the whole logic just to get the parameter in 
the exactly same way doesn't seem to be a good idea as well - as it may not be 
compatible with other containers and their logic. Maybe such a simple solution 
would be ok?

Carsten, were you able to solve this issue somewhere else?

\[1] 
https://github.com/eclipse/jetty.project/blob/master/jetty-server/src/main/java/org/eclipse/jetty/server/Request.java#L1747
\[2] 
https://github.com/eclipse/jetty.project/blob/master/jetty-http/src/main/java/org/eclipse/jetty/http/HttpURI.java#L558

> Semicolon parameters are not passed to the resource resolver
> ------------------------------------------------------------
>
>                 Key: SLING-4804
>                 URL: https://issues.apache.org/jira/browse/SLING-4804
>             Project: Sling
>          Issue Type: Bug
>          Components: Engine
>    Affects Versions: Engine 2.4.2
>            Reporter: Tomek Rękawek
>            Assignee: Tomek Rękawek
>            Priority: Minor
>             Fix For: Engine 2.4.4
>
>         Attachments: SLING-4804-2.patch, SLING-4804.patch
>
>
> SLING-848 provided a way to pass semicolon-separated parameters to the 
> resource provider. However, such parameters are removed from the 
> {{HttpServletRequest#getPathInfo()}}, which is used in the 
> {{RequestData#initResource()}} method to resolve the resource from the URI. 
> As a result, resource resolver and resource provider don't see the semicolon 
> parameters and can't use them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to