[
https://issues.apache.org/jira/browse/SLING-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14586374#comment-14586374
]
Konrad Windszus commented on SLING-4795:
----------------------------------------
Regarding the asynchronous handling of the OSGi events:
Since by default the preload feature is switched on, the query to get all entry
points is executed twice and all properies are getting collected during the
handleEvent by default. That migh easily hit the Felix Event Admin timeout on a
system which is under load (so that the event handler gets blocked for future
events). But I could also contribute this in a dedicated ticket if you prefer
that.
Regarding the limitation of the invalidation:
The main part of the PR is not the asynchronous handling of OSGi events but
rather the limitation of the invalidation effects. This is especially useful if
a 3rd party app (like CQ5 translator) is used to maintain certain translations.
Although changes to resource bundles are not that frequent, all requests are
blocked during the time when the cache is rebuilt from scratch (since
SLING-3758). Since on a bigger installation that might easily take some time,
this patch makes the system responsive again after a shorter timeframe. The
added complexity is negligible IMHO.
> Only discard the ResourceBundles if they are really invalid
> -----------------------------------------------------------
>
> Key: SLING-4795
> URL: https://issues.apache.org/jira/browse/SLING-4795
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: i18n 2.4.4
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
>
> Currently on all changes on the JCR language nodes the full cache in
> {{JcrResourceBundleProvider}} becomes invalid.
> Since most of the changes won't change the actual locale or basename the
> invalidation could be improved so that only that {{JcrResourceBundle}} gets
> invalid, which is having the same locale/basename.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
