[ 
https://issues.apache.org/jira/browse/SLING-4811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593755#comment-14593755
 ] 

Alexander Klimetschek commented on SLING-4811:
----------------------------------------------

The 
[comments|https://github.com/apache/sling/blob/trunk/bundles/extensions/i18n/src/main/java/org/apache/sling/i18n/impl/JcrResourceBundleProvider.java#L289-L290]
 (and 
[here|https://github.com/apache/sling/blob/trunk/bundles/extensions/i18n/src/main/java/org/apache/sling/i18n/impl/JcrResourceBundleProvider.java#L307-L308])
 says 3 seconds, actual value is 5 seconds. I am not a fan of arbitrary wait 
times.

Also, are you sure upon startup initial requests will actually get the current 
dictionary and not empty ones (until that timeout is over)?

> Handle OSGi event in a separate thread to prevent being blacklisted by the 
> OSGi Event Admin
> -------------------------------------------------------------------------------------------
>
>                 Key: SLING-4811
>                 URL: https://issues.apache.org/jira/browse/SLING-4811
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: i18n 2.4.2
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>             Fix For: i18n 2.4.4
>
>         Attachments: SLING-4811-v02.patch
>
>
> Since Apache Felix blacklists all OSGi Event Handlers which take too long to 
> complete it would be good if all long-running tasks would be executed in a 
> separate thread (like preloading resource bundles).
> Otherwise the {{JcrResourceBundleProvider}} might get blacklisted if the 
> instance is under load and in the future is not notified about any changes. 
> The default timeout of Apache Felix is 5 seconds 
> (http://felix.apache.org/documentation/subprojects/apache-felix-event-admin.html).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to