On Wed, 2015-07-29 at 13:34 +0530, Varun Nagpal wrote: > Hi Robert, > > Fixed the issues related to AL headers and reattached the zip archive > with > new md5sum (69576a5b3155684659c1112eb8923274).
Looks good to me, thanks! +1 for accepting the contribution Robert > > Please have a look. > > Thanks. > -- > Varun > > On Fri, Jul 24, 2015 at 7:08 PM, Robert Munteanu <romb...@apache.org> > wrote: > > > On Wed, 2015-07-22 at 19:45 +0530, Varun Nagpal wrote: > > > Hi, > > > > > > This thread is about voting for the acceptance of the Log Tail > > > Plugin > > > tracked in SLING-4897. > > > > > > An archive (sling-logtail.zip, md5sum > > > 6d14f2ef4748c00e63cbbaeda7224e3c) > > > containing the contribution is attached to SLING-4897 and > > > otherwise > > > available at [0]. > > > > With a rat check some files fail due to missing/unapproved > > licenses: > > > > Unapproved licenses: > > > > > > src/main/java/org/apache/sling/tail/impl/LogTailerWebConsolePlugin > > .jav > > a > > src/main/java/org/apache/sling/tail/LogFilter.java > > src/main/resources/libs/tail/css/tail.css > > src/main/resources/libs/tail/js/tail.js > > pom.xml > > > > To reproduce, change the parent pom version from 22 to 24 and run > > > > mvn verify > > > > This should be fixed before accepting the contribution. > > > > Thanks, > > > > Robert > >
