[ 
https://issues.apache.org/jira/browse/SLING-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682429#comment-14682429
 ] 

Georg Henzler commented on SLING-4862:
--------------------------------------

Thanks for your comments [~bdelacretaz], updated the patch as follows:
- Output is encoded using org.apache.commons.lang.StringEscapeUtils (commons 
lang is already a dependency)
- format can be given as extension, but a "helper segment" has to be given in 
path: /system/health/result.json or just /system/health/.json. Unfortunately 
/system/health.json does not work as there has to be at least one slash after 
the base path that is registered using httpService.registerServlet()
- removed "modified" method
- using css class "status" + status.name() now
- changed method "service" to doGet (you are right, other methods do not make 
sense)
- status mapping can be configured ala 
httpStatus=CRITICAL:503,HEALTH_CHECK_ERROR:500
- added a unit test for the servlet (this required to add an equals() to 
HealthCheckExecutionOptions)



> Sling Health Checks Servlet
> ---------------------------
>
>                 Key: SLING-4862
>                 URL: https://issues.apache.org/jira/browse/SLING-4862
>             Project: Sling
>          Issue Type: Improvement
>          Components: Health Check
>            Reporter: Bertrand Delacretaz
>            Priority: Minor
>         Attachments: SLING-4862-HealthCheckExecutorServlet.patch
>
>
> A Servlet that can execute health checks would be useful.
> It can take as input the tags of the HCs to execute, and output their results 
> in JSON format.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to