[ 
https://issues.apache.org/jira/browse/SLING-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725446#comment-14725446
 ] 

Konrad Windszus commented on SLING-4734:
----------------------------------------

I for sure don't want that. But since I cannot prevent the {{JavaUserProvider}} 
from also instantiating models (e.g. in case the {{ModelFactoryUseProvider}} is 
not deployed) I would rather make the behaviour consistent.

> Sightly should try to instantiate Sling Models first via 
> SlingHttpServletRequest then via Resource and not the other way around
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SLING-4734
>                 URL: https://issues.apache.org/jira/browse/SLING-4734
>             Project: Sling
>          Issue Type: Improvement
>          Components: Scripting
>    Affects Versions: Scripting Sightly Models Use Provider 1.0.0
>            Reporter: Konrad Windszus
>             Fix For: Scripting Sightly Models Use Provider 1.0.0
>
>
> Currently the {{JavaUseProvider}} first tries to instantiate Sling Models via 
> the {{Resource}} then via the {{SlingHttpServletRequest}}. I would argue that 
> the inverse order makes more sense, because more injections are supported via 
> the {{SlingHttpServletRequest}} for Sling Models.
> This would only matter though, where the same class would be adaptable from 
> both {{Resource}} and {{SlingHttpServletRequest}}. In that case though the 
> instantiation via the {{SlingHttpServletRequest}} would support more 
> injections (e.g. the SlingObjectInjector supports much more with the 
> {{SlingHttpServletRequest}}, compare with SLING-4083)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to