little follow up.

Chatiting with a colleague (thanks Francesco!!), he pointed out that probably 
would be more useful to have one MBean per filter. And any MBean would have 
info as


  *   service = org.apache.sling.i18n.impl.I18NFilter

Attributes
Attribute Name  Attribute Value
InvocationsCount        2268
MaxRequestDurationMsec  1000
MinRequestDurationMsec  0
MeanRequestDurationMsec 122.67692307692307
StandardDeviationDurationMsec   134.5240577569106


I think is a great idea!! WDYT?

regards

antonio

On Aug 26, 2015, at 3:29 PM, Antonio Sanso 
<[email protected]<mailto:[email protected]>> wrote:

nice one and  thanks Bertrand .

Really appreciated your feedback!

regards

antonio

On Aug 26, 2015, at 10:34 AM, Bertrand Delacretaz 
<[email protected]<mailto:[email protected]>> wrote:

On Wed, Aug 26, 2015 at 9:25 AM, Antonio Sanso 
<[email protected]<mailto:[email protected]>> wrote:
On Aug 26, 2015, at 9:55 AM, Bertrand Delacretaz 
<[email protected]<mailto:[email protected]>> wrote:
...typically JMX statistics are much more concise than the one we provided in 
the console....

I think the following info (provided in a structured way in JMX) is
all good to have:

0 : class org.apache.sling.launchpad.testservices.filters.SlingFilter
(id: 298, property: none); called: 14; time: 1ms; time/call: 71µs

Min/max timings might also be useful to have.

And if you represent that as a tree of filters organized in categories
that would be convenient IMO, I don't think that's too much
information.

-Bertrand


Reply via email to