[ 
https://issues.apache.org/jira/browse/SLING-5002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731516#comment-14731516
 ] 

Stefan Seifert commented on SLING-5002:
---------------------------------------

yes, we should go away from 0.9.9-RC2 where the {{javassist.version}} property 
is only within a profile, which makes no sense.

unfortuantely i get strange threading issues in my unit tests (running in 
parallelized) with version 0.9.10. example:
{noformat}
testGetHitsNullResilience(de.app.wcm.airport.base.util.teaser.TileUtilTest)  
Time elapsed: 0.02 sec  <<< ERROR!
java.lang.RuntimeException: Executing setup callback failed.
        at 
io.wcm.testing.mock.aem.junit.AemContext.executeSetUpCallback(AemContext.java:162)
        at 
io.wcm.testing.mock.aem.junit.AemContext.access$100(AemContext.java:40)
        at 
io.wcm.testing.mock.aem.junit.AemContext$1.before(AemContext.java:120)
        at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:46)
        at org.junit.rules.RunRules.evaluate(RunRules.java:20)
        at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
        at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
        at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
        at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
        at 
org.apache.maven.surefire.junitcore.pc.Scheduler$1.run(Scheduler.java:387)
        at 
org.apache.maven.surefire.junitcore.pc.InvokerStrategy.schedule(InvokerStrategy.java:54)
        at 
org.apache.maven.surefire.junitcore.pc.Scheduler.schedule(Scheduler.java:346)
        at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
        at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
        at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
        at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
        at org.junit.runners.Suite.runChild(Suite.java:128)
        at org.junit.runners.Suite.runChild(Suite.java:27)
        at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
        at 
org.apache.maven.surefire.junitcore.pc.Scheduler$1.run(Scheduler.java:387)
        at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.IllegalStateException: zip file closed
        at java.util.zip.ZipFile.ensureOpen(ZipFile.java:670)
        at java.util.zip.ZipFile.access$200(ZipFile.java:61)
        at java.util.zip.ZipFile$ZipEntryIterator.hasNext(ZipFile.java:494)
        at 
java.util.zip.ZipFile$ZipEntryIterator.hasMoreElements(ZipFile.java:489)
        at java.util.jar.JarFile$JarEntryIterator.hasNext(JarFile.java:253)
        at 
java.util.jar.JarFile$JarEntryIterator.hasMoreElements(JarFile.java:262)
        at org.reflections.vfs.ZipDir$1$1.computeNext(ZipDir.java:30)
        at org.reflections.vfs.ZipDir$1$1.computeNext(ZipDir.java:26)
        at 
com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
        at 
com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138)
        at org.reflections.Reflections.scan(Reflections.java:240)
        at org.reflections.Reflections.scan(Reflections.java:204)
        at org.reflections.Reflections.<init>(Reflections.java:129)
        at org.reflections.Reflections.<init>(Reflections.java:170)
        at org.reflections.Reflections.<init>(Reflections.java:143)
        at 
org.apache.sling.testing.mock.sling.context.ModelAdapterFactoryUtil$ModelsPackageBundle.findEntries(ModelAdapterFactoryUtil.java:89)
        at 
org.apache.sling.models.impl.ModelPackageBundleListener.addingBundle(ModelPackageBundleListener.java:86)
        at 
org.osgi.util.tracker.BundleTracker$Tracked.customizerAdding(BundleTracker.java:439)
        at 
org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:261)
        at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:233)
        at 
org.osgi.util.tracker.BundleTracker$Tracked.bundleChanged(BundleTracker.java:413)
        at 
org.apache.sling.testing.mock.osgi.MockBundleContext.sendBundleEvent(MockBundleContext.java:249)
        at 
org.apache.sling.testing.mock.osgi.MockOsgi.sendBundleEvent(MockOsgi.java:56)
        at 
org.apache.sling.testing.mock.sling.context.ModelAdapterFactoryUtil.addModelsForPackage(ModelAdapterFactoryUtil.java:59)
        at 
org.apache.sling.testing.mock.sling.context.SlingContextImpl.addModelsForPackage(SlingContextImpl.java:292)
        at 
io.wcm.testing.mock.wcmio.handler.MockHandler.setUp(MockHandler.java:60)
        at 
de.app.wcm.airport.base.testcontext.AppAemContext$SetUpCallback.execute(AppAemContext.java:53)
        at 
io.wcm.testing.mock.aem.junit.AemContext.executeSetUpCallback(AemContext.java:159)
        at 
io.wcm.testing.mock.aem.junit.AemContext.access$100(AemContext.java:40)
        at 
io.wcm.testing.mock.aem.junit.AemContext$1.before(AemContext.java:120)
        at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:46)
        at org.junit.rules.RunRules.evaluate(RunRules.java:20)
        at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
        at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
        at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
        at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
        at 
org.apache.maven.surefire.junitcore.pc.Scheduler$1.run(Scheduler.java:387)
        at 
org.apache.maven.surefire.junitcore.pc.InvokerStrategy.schedule(InvokerStrategy.java:54)
        at 
org.apache.maven.surefire.junitcore.pc.Scheduler.schedule(Scheduler.java:346)
        at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
        at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
        at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
        at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
        at org.junit.runners.Suite.runChild(Suite.java:128)
        at org.junit.runners.Suite.runChild(Suite.java:27)
        at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
        at 
org.apache.maven.surefire.junitcore.pc.Scheduler$1.run(Scheduler.java:387)
        at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745){noformat}
{noformat}

Completed: At revision: 1701331
i've switched back to 0.9.9 which is running fine in parallel.
the property problem is fixed in this version as well still solving your 
problem (please retest).

> [sling-mock] Update dependency version of org.reflections
> ---------------------------------------------------------
>
>                 Key: SLING-5002
>                 URL: https://issues.apache.org/jira/browse/SLING-5002
>             Project: Sling
>          Issue Type: Improvement
>          Components: Testing
>    Affects Versions: Testing Sling Mock 1.4.0
>            Reporter: Julian Sedding
>            Assignee: Julian Sedding
>             Fix For: Testing Sling Mock 1.5.0
>
>
> Currently sling-mock has a dependency on 
> {{org.reflections:reflections:0.9.9-RC2}}. This in turn has a transitive 
> dependency on {{org.javassist:javassist}} with the version set to 
> {{javassist.version}} (i.e. not interpolated).
> This causes issues in a gradle build I use at a client. Updating sling-mock's 
> dependency to {{org.reflections:reflections:0.9.10}} seems to fix the issue 
> and looks like it's the right thing to do anyways.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to