[
https://issues.apache.org/jira/browse/SLING-5025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-5025:
-----------------------------------
Attachment: SLING-5025.v02.diff
Attached is a second patch incorporating [~cziegeler]s feedback.
I am still not sure about the {{context.isLive()}} check
(http://www.mail-archive.com/[email protected]/msg49389.html).
I included that also in the {{checkClosed}} method as suggested, but as far as
I can see, even if that returns {{false}}, the ResourceResolver will not be
automatically closed, therefore the javadoc might not fit 100% in that case.
[~cziegeler] Do you have a suggestion on how to state that correctly in the
javadoc of ResourceResolver?
> Make ResourceResolver methods throw ISE in case the according factory is
> unregistered
> -------------------------------------------------------------------------------------
>
> Key: SLING-5025
> URL: https://issues.apache.org/jira/browse/SLING-5025
> Project: Sling
> Issue Type: Improvement
> Components: ResourceResolver
> Affects Versions: Resource Resolver 1.2.6
> Reporter: Konrad Windszus
> Attachments: SLING-5025-api.v01.diff,
> SLING-5025-resourceresolver.v01.diff, SLING-5025.v02.diff
>
>
> In SLING-4360 the {{ResourceResolver.isLive()}} method was extended to check
> if the {{ResourceResolverFactory}} has been unregistered in the mean time.
> That check should be done in addition for every method on the resource
> resolver and should throw an ISE in case the factory is no longer registered.
> See also the discussion at
> http://www.mail-archive.com/[email protected]/msg49364.html.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
