[
https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936650#comment-14936650
]
Joel Richard commented on SLING-4585:
-------------------------------------
[~cziegeler], the tests are intended to ensure that the behaviour between the
two ways of retrieving the items is exactly the same. I think they are
necessary because the old way, for example, would not have thrown an exception
for empty paths while jackrabbitSession.getItemOrNull throws one. Therefore, it
needs some special handling to ensure that the behaviour is the same and I
think this should have test coverage because otherwise it might happen that
somebody will remove the special handling in the future.
The snapshot dependencies are not meant to be committed to the Sling code base
(which is indicated by the todo above).
> Performance: Use JackrabbitSession#getItemOrNull to speed up
> JcrResourceProvider#createResource
> -----------------------------------------------------------------------------------------------
>
> Key: SLING-4585
> URL: https://issues.apache.org/jira/browse/SLING-4585
> Project: Sling
> Issue Type: Improvement
> Components: JCR, ResourceResolver
> Affects Versions: JCR Resource 2.5.0
> Reporter: Joel Richard
> Priority: Critical
> Labels: performance
> Attachments:
> 0001-SLING-4585-Performance-Use-JackrabbitSession-getItem.patch
>
>
> If the current session is a JackrabbitSession, JcrResourceProvider should use
> getItemOrNull (as soon as exported) to save rendering time.
> See referenced issue and the following mail thread for more information:
> http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/%3CD1495A09.3B670%25anchela%40adobe.com%3E
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
