[
https://issues.apache.org/jira/browse/SLING-5152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14958941#comment-14958941
]
Joel Richard commented on SLING-5152:
-------------------------------------
[~rombert], quoting [~anchela] from another conversation:
{quote}Looking at the implementation in Jackrabbit core it have the impression
that in the reference implementation we interpreted this such that
Property.isMultiple returns true if PropertyDefinition.isMultiple returns true.
So, I would take this as de facto standard even if the spec might be a little
bit ambiguous here.{quote}
Since JsonJcrNode/JsonItemWriter operates with the property values, it makes
more sense to use property.isMultiple() anyway in my opinion.
> JsonJcrNode and JsonItemWriter should use prop.isMultiple() instead of
> def.isMultiple()
> ---------------------------------------------------------------------------------------
>
> Key: SLING-5152
> URL: https://issues.apache.org/jira/browse/SLING-5152
> Project: Sling
> Issue Type: Improvement
> Components: Commons
> Affects Versions: Commons JSON 2.0.12
> Reporter: Joel Richard
> Priority: Minor
> Labels: json, performance
>
> In Oak, node.getDefinition().isMultiple() is is around 35 times slower than
> prop.isMultiple(). In addition to this, MockProperty.isMultiple has to be
> implemented because otherwise the tests fail (for which I will open another
> issue shortly).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
