Applied the change in https://svn.apache.org/viewvc?view=revision&revision=r1710785.
On Tue, 27 Oct 2015 at 12:27 Radu Cotescu <[email protected]> wrote: > Hi Carsten, > > We should probably _temporarily_ increase the threshold for the Sling > Models Sightly performance test, although the proper fix would be improving > how Sling Models are initialised. The reflection code we have now is not > optimal. > > Cheers, > Radu > > > On Tue, 27 Oct 2015 at 09:58 Carsten Ziegeler <[email protected]> > wrote: > >> Hi, >> >> when building trunk I repeatedly get a test failure in the >> sightly.testing module. Can this please be fixed? >> >> >> test5SlyJavaSlingModels(org.apache.sling.scripting.sightly.it.performance.PerformanceIT) >> Time elapsed: 9.086 sec <<< ERROR! >> java.lang.Exception: Threshold exceeded! Expected < 2,00, actual 2,02 >> at >> >> org.apache.sling.performance.ReportLogger.checkThresholds(ReportLogger.java:421) >> at >> >> org.apache.sling.performance.ReportLogger.checkAllThresholds(ReportLogger.java:342) >> at >> >> org.apache.sling.performance.PerformanceRunner.run(PerformanceRunner.java:115) >> at >> >> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283) >> at >> >> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173) >> at >> >> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) >> at >> >> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128) >> at >> >> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203) >> at >> >> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155) >> at >> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103) >> >> >> Results : >> >> Tests in error: >> >> org.apache.sling.scripting.sightly.it.performance.PerformanceIT.test5SlyJavaSlingModels(org.apache.sling.scripting.sightly.it.performance.PerformanceIT) >> Run 1: PASS >> Run 2: PerformanceIT.test5SlyJavaSlingModels ยป Threshold exceeded! >> Expected < 2,00,... >> -- >> Carsten Ziegeler >> Adobe Research Switzerland >> [email protected] >> >
