[
https://issues.apache.org/jira/browse/SLING-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006775#comment-15006775
]
Stefan Egli commented on SLING-5299:
------------------------------------
Other recent test failures with the same pattern/fix include:
*
https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.discovery.impl/2714/testReport/org.apache.sling.discovery.impl.common.heartbeat/HeartbeatTest/testPartitioning/
*
https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.discovery.impl/1997/testReport/org.apache.sling.discovery.impl.common.heartbeat/HeartbeatTest/testPartitioningWithFailingScheduler/
> HeartbeatTest.testPartitioning failed due to not waiting long enough
> --------------------------------------------------------------------
>
> Key: SLING-5299
> URL: https://issues.apache.org/jira/browse/SLING-5299
> Project: Sling
> Issue Type: Test
> Components: Extensions
> Affects Versions: Discovery Impl 1.2.2
> Reporter: Stefan Egli
> Assignee: Stefan Egli
> Fix For: Discovery Impl 1.2.4
>
>
> Following test failed:
> https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.discovery.impl/1997/testReport/org.apache.sling.discovery.impl.common.heartbeat/HeartbeatTest/testPartitioning/
> with: {code}
> java.lang.AssertionError: null
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertNotNull(Assert.java:621)
> at org.junit.Assert.assertNotNull(Assert.java:631)
> at
> org.apache.sling.discovery.impl.common.heartbeat.HeartbeatTest.doTestPartitioning(HeartbeatTest.java:272)
> at
> org.apache.sling.discovery.impl.common.heartbeat.HeartbeatTest.testPartitioning(HeartbeatTest.java:141){code}
> the error log, grepped for relevant parts, shows that for {{fast2}} the
> {{TOPOLOGY_INIT}} was indeed not yet delivered - but might just have been
> would the test have waited for another perhaps 500ms or so:
> {code}
> 11.11.2015 19:38:41.549 *INFO * [VotingEventListener-slow]
> cbe7d989-07c8-4aec-a1df-f05ce08f16ad: promote: promotion done (#members: 5,
> path:
> /var/discovery/impl/establishedView/a24bff2e-6db0-4d34-becf-33860ffa2319)
> 11.11.2015 19:38:42.456 *DEBUG*
> [discovery.connectors.common.runner.f513f03c-02d4-473a-9688-7e6d3f8a0210]
> HeartbeatHandler: issueClusterLocalHeartbeat: storing cluster-local heartbeat
> to repository for f513f03c-02d4-473a-9688-7e6d3f8a0210
> 11.11.2015 19:38:42.562 *INFO * [main] HeartbeatTest: doTestPartitioning:
> --------------------------------
> 11.11.2015 19:38:42.562 *INFO * [main] HeartbeatTest: doTestPartitioning:
> doing pinging with hhSlow now...
> 11.11.2015 19:38:42.562 *INFO * [main] HeartbeatTest: doTestPartitioning:
> --------------------------------
> 11.11.2015 19:38:42.665 *DEBUG* [main] HeartbeatHandler:
> issueClusterLocalHeartbeat: storing cluster-local heartbeat to repository for
> cbe7d989-07c8-4aec-a1df-f05ce08f16ad
> 11.11.2015 19:38:42.794 *DEBUG*
> [discovery.connectors.common.runner.9e26948e-a7ba-40b2-a221-ba2de8fe91bc]
> HeartbeatHandler: issueClusterLocalHeartbeat: storing cluster-local heartbeat
> to repository for 9e26948e-a7ba-40b2-a221-ba2de8fe91bc
> 11.11.2015 19:38:42.806 *DEBUG*
> [discovery.connectors.common.runner.5bb82d24-18ac-4ab0-a01a-7b483ff0839d]
> HeartbeatHandler: issueClusterLocalHeartbeat: storing cluster-local heartbeat
> to repository for 5bb82d24-18ac-4ab0-a01a-7b483ff0839d
> 11.11.2015 19:38:42.834 *DEBUG*
> [discovery.connectors.common.runner.65f5e0ca-54f4-4cfb-88eb-fe2e9e652879]
> HeartbeatHandler: issueClusterLocalHeartbeat: storing cluster-local heartbeat
> to repository for 65f5e0ca-54f4-4cfb-88eb-fe2e9e652879
> 11.11.2015 19:38:43.744 *INFO * [Discovery-AsyncEventSender]
> ViewStateManagerImpl: enqueueForAll: sending topologyEvent TopologyEvent
> [type=TOPOLOGY_INIT, oldView=null, newView=DefaultTopologyView[current=true,
> num=5,
> instances=65f5e0ca-54f4-4cfb-88eb-fe2e9e652879[local=true,leader=false],cbe7d989-07c8-4aec-a1df-f05ce08f16ad[local=false,leader=true],f513f03c-02d4-473a-9688-7e6d3f8a0210[local=false,leader=false],9e26948e-a7ba-40b2-a221-ba2de8fe91bc[local=false,leader=false],5bb82d24-18ac-4ab0-a01a-7b483ff0839d[local=false,leader=false]]],
> to all (2) listeners
> 11.11.2015 19:38:43.743 *INFO * [SyncTokenService] ViewStateManagerImpl:
> enqueueForAll: sending topologyEvent TopologyEvent [type=TOPOLOGY_INIT,
> oldView=null, newView=DefaultTopologyView[current=true, num=5,
> instances=65f5e0ca-54f4-4cfb-88eb-fe2e9e652879[local=false,leader=false],cbe7d989-07c8-4aec-a1df-f05ce08f16ad[local=true,leader=true],f513f03c-02d4-473a-9688-7e6d3f8a0210[local=false,leader=false],9e26948e-a7ba-40b2-a221-ba2de8fe91bc[local=false,leader=false],5bb82d24-18ac-4ab0-a01a-7b483ff0839d[local=false,leader=false]]],
> to all (2) listeners
> 11.11.2015 19:38:43.747 *INFO * [Discovery-AsyncEventSender]
> ViewStateManagerImpl: enqueueForAll: sending topologyEvent TopologyEvent
> [type=TOPOLOGY_INIT, oldView=null, newView=DefaultTopologyView[current=true,
> num=5,
> instances=65f5e0ca-54f4-4cfb-88eb-fe2e9e652879[local=false,leader=false],cbe7d989-07c8-4aec-a1df-f05ce08f16ad[local=false,leader=true],f513f03c-02d4-473a-9688-7e6d3f8a0210[local=false,leader=false],9e26948e-a7ba-40b2-a221-ba2de8fe91bc[local=true,leader=false],5bb82d24-18ac-4ab0-a01a-7b483ff0839d[local=false,leader=false]]],
> to all (2) listeners
> 11.11.2015 19:38:43.749 *INFO * [Discovery-AsyncEventSender]
> HeartbeatTest$SimpleTopologyEventListener: handleTopologyEvent[slow]:
> TOPOLOGY_INIT, newView contains 5, newView.isCurrent=true
> 11.11.2015 19:38:43.750 *INFO * [Discovery-AsyncEventSender]
> HeartbeatTest$SimpleTopologyEventListener: handleTopologyEvent[fast4]:
> TOPOLOGY_INIT, newView contains 5, newView.isCurrent=true
> 11.11.2015 19:38:43.750 *INFO * [Discovery-AsyncEventSender]
> HeartbeatTest$SimpleTopologyEventListener: handleTopologyEvent[fast3]:
> TOPOLOGY_INIT, newView contains 5, newView.isCurrent=true
> 11.11.2015 19:38:43.780 *DEBUG*
> [discovery.connectors.common.runner.f513f03c-02d4-473a-9688-7e6d3f8a0210]
> HeartbeatHandler: issueClusterLocalHeartbeat: storing cluster-local heartbeat
> to repository for f513f03c-02d4-473a-9688-7e6d3f8a0210
> 11.11.2015 19:38:43.806 *INFO * [Discovery-AsyncEventSender]
> DiscoveryServiceImpl: changePropagationListener.handleTopologyEvent: topology
> changed - propagate through connectors
> 11.11.2015 19:38:43.828 *INFO * [Discovery-AsyncEventSender]
> ViewStateManagerImpl: enqueueForAll: sending topologyEvent TopologyEvent
> [type=TOPOLOGY_INIT, oldView=null, newView=DefaultTopologyView[current=true,
> num=5,
> instances=65f5e0ca-54f4-4cfb-88eb-fe2e9e652879[local=false,leader=false],cbe7d989-07c8-4aec-a1df-f05ce08f16ad[local=false,leader=true],f513f03c-02d4-473a-9688-7e6d3f8a0210[local=true,leader=false],9e26948e-a7ba-40b2-a221-ba2de8fe91bc[local=false,leader=false],5bb82d24-18ac-4ab0-a01a-7b483ff0839d[local=false,leader=false]]],
> to all (2) listeners
> 11.11.2015 19:38:43.830 *INFO * [Discovery-AsyncEventSender]
> HeartbeatTest$SimpleTopologyEventListener: handleTopologyEvent[fast1]:
> TOPOLOGY_INIT, newView contains 5, newView.isCurrent=true
> 11.11.2015 19:38:44.295 *INFO * [main] HeartbeatTest: doTestPartitioning: all
> 4 instances should have agreed on seeing each other
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
