[
https://issues.apache.org/jira/browse/SLING-5463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124915#comment-15124915
]
Carsten Ziegeler commented on SLING-5463:
-----------------------------------------
The previous code (before SLING-4585) did not call session.itemExists directly,
but the following method which simply catches RepositoryException. I think we
should reintroduce behaviour. However, while this is easy for the
itemExists/getItem pattern, catching and ignoring the exception for
getItemOrNull() might be wrong as this would mean we ignore all exceptions from
there.
private boolean itemExists(final String path) {
try {
return session.itemExists(path);
} catch (RepositoryException re) {
log.debug("itemExists: Error checking for existence of {}: {}",
path, re.toString());
return false;
}
}
> GetStarTest fails with "Invalid name or path"
> ---------------------------------------------
>
> Key: SLING-5463
> URL: https://issues.apache.org/jira/browse/SLING-5463
> Project: Sling
> Issue Type: Bug
> Components: JCR, Testing
> Reporter: Bertrand Delacretaz
> Assignee: Robert Munteanu
> Labels: sling-IT
> Fix For: JCR Resource 2.6.0
>
>
> The GetStarTest from launchpad/integration-tests recently started failing,
> for example at [1]:
> {code}
> javax.jcr.RepositoryException: Invalid name or path:
> /GetStarTest1453972215267/*
> at
> org.apache.jackrabbit.oak.jcr.session.SessionContext.getOakPathOrThrow(SessionContext.java:347)
> ...
> at
> org.apache.jackrabbit.oak.jcr.session.SessionImpl.getItemOrNull(SessionImpl.java:225)
> at
> org.apache.sling.jcr.resource.internal.helper.jcr.JcrItemResourceFactory.getItemOrNull(JcrItemResourceFactory.java:182)
> at
> org.apache.sling.jcr.resource.internal.helper.jcr.JcrItemResourceFactory.createResource(JcrItemResourceFactory.java:96)
> at
> org.apache.sling.jcr.resource.internal.helper.jcr.JcrResourceProvider.listChildren(JcrResourceProvider.java:293)
> at
> org.apache.sling.resourceresolver.impl.providers.stateful.AuthenticatedResourceProvider.listChildren(AuthenticatedResourceProvider.java:175)
> at
> org.apache.sling.resourceresolver.impl.providers.stateful.CombinedResourceProvider.listChildren(CombinedResourceProvider.java:205)
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.listChildren(ResourceResolverImpl.java:719)
> at
> org.apache.sling.api.resource.ResourceUtil.listChildren(ResourceUtil.java:360)
> ...
> at
> org.apache.sling.servlets.get.impl.helpers.JsonRendererServlet.doGet(JsonRendererServlet.java:100)
> {code}
> [1]
> https://builds.apache.org/view/S-Z/view/Sling/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/3252/testReport/junit/org.apache.sling.launchpad.webapp.integrationtest/GetStarTest/testGetStarJson/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
