On Thu, 2016-02-04 at 07:28 +0000, Stefan Seifert wrote: > -1 for the API bundle (unless this is by intention:) > > why have we in the new API bundle two different packages with path- > related utility classes? > > org.apache.sling.api.resource.util (SLING-5220, comparing paths) > Path > PathSet > > org.apache.sling.resource.path (SLING-5455, bulding paths) > PathBuilder > > the latter is even missing the "api" part in the package name - is > this by intention? > perhaps Path and PathBuilder could even be combined in one single > class.
That's a good point. I initially added the PathBuilder after I got tired of too many String-based operations ( which are easy to get wrong when working with paths ). The PathBuilder is aimed to be more lightweight than a Path when just need to craft a String path to pass to the ResourceResolver or a similar API. It's outside the api.resource.util package since it's a standalone utility that might move outside the API bundle in the future, if we get more path-related utilities in. That being said, I see three options: 1. Go ahead with the release, given the above arguments 2. Move Path and PathSet to the resource.path package, for consistency 3. Move pack PathBuilder to the resourceresolver package as an internal class Thoughts? Robert > > stefan > > > > -----Original Message----- > > From: Robert Munteanu [mailto:[email protected]] > > Sent: Tuesday, February 02, 2016 10:34 PM > > To: Sling Dev > > Subject: [VOTE] Release Apache Sling API 2.10.0, Apache Sling > > Resource > > Resolver 1.3.0, Apache Sling JCR Resource Resolver 2.6.0, Apache > > Sling > > Servlet Resolver 2.3.10 > > > > Hi, > > > > We solved a large number of issues issues in these releases: > > > > https://issues.apache.org/jira/browse/SLING/fixforversion/12329540 > > ( > > Apache Sling API 2.10.0, 21 issues) > > https://issues.apache.org/jira/browse/SLING/fixforversion/12332988 > > ( > > Apache Sling Resource Resolver 1.3.0, 22 issues ) > > https://issues.apache.org/jira/browse/SLING/fixforversion/12333342 > > ( > > Apache Sling JCR Resource Resolver 2.6.0, 12 issues ) > > https://issues.apache.org/jira/browse/SLING/fixforversion/12333753 > > ( > > Apache Sling Servlet Resolver 2.3.10, 3 issues) > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-1 > > 416/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh > > > > Usage: > > sh check_staged_release.sh 1416 /tmp/sling-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours.
