[
https://issues.apache.org/jira/browse/SLING-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140940#comment-15140940
]
Julian Sedding commented on SLING-5468:
---------------------------------------
[~kwin] I am in the same position as Carsten, I don't know the code.
Anyway, a few comments:
- I like separating {{CommonMergedResourceProviderTest}} from the Picker
implementations. The separation of concerns makes it easier to follow.
- I noticed one occasion in the {{CommonMergedResourceProviderTest}} where it
says {{relativePath != "/"}}. This is never false.
- Maybe having three levels of overlayed resources in
{{CommonMergedResourceProviderTest}} would be good. Only two levels can easily
work while three may already fail. (Not claiming that it does fail! However,
adding the extra test coverage should be easy now).
> Resource Merger: Provide a way to completely replace the underlying resources
> -----------------------------------------------------------------------------
>
> Key: SLING-5468
> URL: https://issues.apache.org/jira/browse/SLING-5468
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: Resource Merger 1.2.10
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Fix For: Resource Merger 1.3.2
>
> Attachments: SLING-5468-v1.patch
>
>
> Currently whenever the mount point of the {{MergingResourcePicker}}
> (/mnt/overlay) or {{OverridingResourcePicker}} (/mnt/override) is used, the
> merging always takes place. It is only possible to hide/modify individual
> resource/properties of the underlying resources but not to completely disable
> the inheritance (and by that replace the whole overriden/overlaid resource).
> A concrete usecase for that is in a CMS (e.g. AEM) where the dialog
> definitions are always loaded via /mnt/override/<resource type>. In that case
> it is not easily possible to completely replace the dialog of the resource
> super type (as only individual child resources or properties can be hidden
> but there is no special property to ignore the inherited resource
> alltogether).
> I propose the following:
> Add a new property {{sling:disregardInheritedResource=true}} in which case
> all the inherited resources would not be taken into account for merging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
