[ https://issues.apache.org/jira/browse/SLING-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145701#comment-15145701 ]
Alexander Klimetschek commented on SLING-5274: ---------------------------------------------- Thanks Bertrand for SLING-5489, it's a good start. For the record, here are the other features in my patch that aren't covered and that might be useful: * include requests with authentication failures in the request history console ** done using RequestHistoryConsolePlugin.recordRequest(request) at the end of handleSecurity() when it returns false; also required some changes in RequestHistoryConsolePlugin to not rely on SlingHttpServletRequest and getPathInfo(), plus appropriate logging in handleSecurity() * more detailed logging inside SlingAuthenticator for the individual authentication steps AFAICS, these changes shouldn't depend on the switch to the OSGi http whiteboard implementation, but I don't know for sure. > Include authentication in RequestProgressTracker > ------------------------------------------------ > > Key: SLING-5274 > URL: https://issues.apache.org/jira/browse/SLING-5274 > Project: Sling > Issue Type: Improvement > Components: Engine > Reporter: Alexander Klimetschek > Attachments: SLING-5274-bertrand.patch, SLING-5274.patch > > > The request progress tracker only starts with the sling filters, after the > sling authentication ran through. Since authentication steps can be complex > with multiple handlers (just like filters) and can have a major performance > impact (custom auth handlers, slow resource resolver login) it would be very > useful to include it with detailed information. -- This message was sent by Atlassian JIRA (v6.3.4#6332)