For me both SLING-5415 and SLING-4941 are additions only (which add new functionality). Of course it would be nice to have unit tests for those, but those patches should not destroy existing functionality. If the added functionality contains some bugs it is definitely not nice, but not a regression IMHO (since that feature has not been available before).
If you already consider the old functionality of health checks being covered with sufficient unit tests/ITs we can be pretty sure, that the added functionality do not have any negative impact. I can only talk about myself: No, I don't have any plans on adding unit tests for those issues. Konrad > On 25 Feb 2016, at 14:22, Bertrand Delacretaz <[email protected]> wrote: > > Hi, > > On Thu, Feb 25, 2016 at 9:50 AM, Konrad Windszus <[email protected]> wrote: >> ...I applied both outstanding patches in SLING-5415 and SLING-4417... > > I don't see any tests for these patches - considering that this is > about health checks I'm not keen on releasing without having solid > tests. > > At least for SLING-5415 - the other one is just an annotation, less > critical I guess. > > Do you guys have plans for adding tests? > > The same goes for SLING-4941 which was committed a while ago. > > -Bertrand
