[
https://issues.apache.org/jira/browse/SLING-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170530#comment-15170530
]
ASF GitHub Bot commented on SLING-5415:
---------------------------------------
GitHub user ghenzler opened a pull request:
https://github.com/apache/sling/pull/125
SLING-5415 adapted existing unit test to check extra logs in timeout
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ghenzler/sling SLING-5415-unit-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/sling/pull/125.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #125
----
commit e02a5862fda830c6356d1eb2f8a0850fdfec8fba
Author: georg.henzler <[email protected]>
Date: 2016-02-27T10:06:14Z
SLING-5415 adapted existing unit test to check extra logs in timeout
----
> For timed-out health checks, show result of last finished result
> -----------------------------------------------------------------
>
> Key: SLING-5415
> URL: https://issues.apache.org/jira/browse/SLING-5415
> Project: Sling
> Issue Type: Improvement
> Components: Health Check
> Reporter: Georg Henzler
> Assignee: Konrad Windszus
> Fix For: Health Check Core 1.2.4
>
> Attachments: SLING-5415-enrich-timeout-results-with-last-result.patch
>
>
> For the case a HC times out, it would be nice to include the log of the last
> result in the timeout result. That way it gets clearer what the health of the
> actual aspect being checked for is. Also, if the last result was CRITICAL, a
> timeout cannot invalidly "downgrade" an actual CRITICAL system state to WARN.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
