[
https://issues.apache.org/jira/browse/SLING-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15183273#comment-15183273
]
Konrad Windszus commented on SLING-5589:
----------------------------------------
If we agree on moving forward towards Java 8 I am fine with that patch. Just
one minor nitpick: I would rather use the version with a type parameter
{{Resource}} for {{org.apache.sling.validation.impl.ValidationServiceImplTest}}
so that there is no need to do any casts.
> Remove dependency commons-collections
> -------------------------------------
>
> Key: SLING-5589
> URL: https://issues.apache.org/jira/browse/SLING-5589
> Project: Sling
> Issue Type: Improvement
> Components: Validation
> Reporter: Oliver Lietz
> Fix For: Validation 1.0.0
>
> Attachments: SLING-5589.patch
>
>
> The only class (interface) used from commons-collections is
> [{{org.apache.commons.collections.Predicate}}|http://commons.apache.org/proper/commons-collections/javadocs/api-3.2.2/org/apache/commons/collections/Predicate.html].
> We should use
> [{{java.util.function.Predicate}}|https://docs.oracle.com/javase/8/docs/api/java/util/function/Predicate.html]
> (which requires Java 8) or provide our own interface.
> [~cziegeler], [~kwin]: WDYT?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
