[ 
https://issues.apache.org/jira/browse/SLING-5596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189261#comment-15189261
 ] 

Julian Reschke commented on SLING-5596:
---------------------------------------

I have only limited knowledge about what's going on; but the patch looks 
plausible.

(Nits: some whitespace-only lines, and for consistency with the existing code 
it might be good to have

   final String protectedHandlers = 
OsgiUtil.toString(config.get(PROP_PROTECTED_HANDLERS), 
DEFAULT_PROTECTED_HANDLERS);

and then use that for initProps.

(this is really a nit; the main benefit that it would have made it slightly 
simpler to understand the change)


> Expose JR protected-handlers in davex
> -------------------------------------
>
>                 Key: SLING-5596
>                 URL: https://issues.apache.org/jira/browse/SLING-5596
>             Project: Sling
>          Issue Type: Bug
>          Components: JCR
>    Affects Versions: JCR DavEx 1.3.2
>            Reporter: Davide Giannella
>            Assignee: Stefan Egli
>            Priority: Blocker
>             Fix For: JCR Davex 1.3.4
>
>         Attachments: SLING-5596.patch
>
>
> After the update of davex to JR 2.12.1 (SLING-5572), the
> JcrRemotingServlet requires a new configuration.
> See the [attached patch|^SLING-5596.patch] that should expose the settings as 
> OSGi
> property providing the same default as [JR config 
> file|https://github.com/apache/jackrabbit/blob/c01502860274f1938b6d94811a09528c342dc03a/jackrabbit-jcr-server/src/test/resources/protectedHandlersConfig.xml].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to