[ 
https://issues.apache.org/jira/browse/SLING-5664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245478#comment-15245478
 ] 

Bertrand Delacretaz commented on SLING-5664:
--------------------------------------------

Thanks for clarifying, I agree with not using {{SlingScriptrHelper}} anymore, 
unless someone else objects.

bq. Those services will be released later, depending on the garbage collection

Ok, if needed we can later add a mechanism to register service references for 
cleanup when the request is closed. That would be cleaner than the trick that 
you describe, which was not obvious to me by looking at the code.


> Models: OSGiServiceInjector does not consider service.ranking
> -------------------------------------------------------------
>
>                 Key: SLING-5664
>                 URL: https://issues.apache.org/jira/browse/SLING-5664
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: Sling Models Impl 1.2.6
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>             Fix For: Sling Models Impl 1.2.8
>
>         Attachments: SLING-5664-v01.patch
>
>
> The injector is using {{BundleContext.getServiceReferences(Class, String)}} 
> or {{SlingScriptHelper.getServices(Class, String)}} 
> (https://github.com/apache/sling/blob/trunk/bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/injectors/OSGiServiceInjector.java#L97).
>  From the returned array it just takes the first item.
> Unfortunately the order in that array is not-deterministic, especially it is 
> not necessarily that way that items with a higher service.ranking are 
> returned first.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to