Re: svn commit: r1739128 - /sling/trunk/bundles/extensions/validation/core/src/main/java/org/apache/sling/validation/impl/CompositeValidationResult.java

[Oliver Lietz]

On Monday 18 April 2016 16:13:56 Robert Munteanu wrote:
> On Thu, 2016-04-14 at 15:50 +0000, o...@apache.org wrote:
> > Author: olli
> > Date: Thu Apr 14 15:50:05 2016
> > New Revision: 1739128
> > 
> > URL: http://svn.apache.org/viewvc?rev=1739128&view=rev
> > Log:
> > fix typo in comment
> > 
> > Modified:
> >     sling/trunk/bundles/extensions/validation/core/src/main/java/org/
> > apache/sling/validation/impl/CompositeValidationResult.java
> > 
> > Modified:
> > sling/trunk/bundles/extensions/validation/core/src/main/java/org/apac
> > he/sling/validation/impl/CompositeValidationResult.java
> > URL: http://svn.apache.org/viewvc/sling/trunk/bundles/extensions/vali
> > dation/core/src/main/java/org/apache/sling/validation/impl/CompositeV
> > alidationResult.java?rev=1739128&r1=1739127&r2=1739128&view=diff
> > =====================================================================
> > =========
> > ---
> > sling/trunk/bundles/extensions/validation/core/src/main/java/org/apac
> > he/sling/validation/impl/CompositeValidationResult.java (original)
> > +++
> > sling/trunk/bundles/extensions/validation/core/src/main/java/org/apac
> > he/sling/validation/impl/CompositeValidationResult.java Thu Apr 14
> > 15:50:05 2016
> > @@ -49,7 +49,7 @@ public class CompositeValidationResult i
> >  
> >      @Override
> >      public boolean isValid() {
> > -        // this is only valid iff all aggregated results are valid
> > +        // this is only valid if all aggregated results are valid
> 
> Maybe this was not a typo? iff also stands for 'if and only if'

Konrad,

was it at typo or did you mean iff?

Robert, where do you see two statements?

Thanks,
O.

> Robert
> 
> >          for (ValidationResult result : results) {
> >              if (!result.isValid()) {
> >                  return false;