[ 
https://issues.apache.org/jira/browse/SLING-5703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264053#comment-15264053
 ] 

ASF GitHub Bot commented on SLING-5703:
---------------------------------------

GitHub user dulvac opened a pull request:

    https://github.com/apache/sling/pull/136

    Sling testing tools split and http and rules contribution

    See SLING-5703

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dulvac/sling sling-testing-tools

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/sling/pull/136.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #136
    
----
commit 18b4762de5e0ee43e3ec3231900a9f83f6dce861
Author: Andrei Dulvac <[email protected]>
Date:   2016-04-22T09:35:24Z

    Split http clients and serversetup modules from sling-testing-tools

commit 581e70e2f2c5ca9c14bba7511aade75547cf479b
Author: Andrei Dulvac <[email protected]>
Date:   2016-04-22T14:41:05Z

    Added patches from it-framework

commit b9491c2bec447400b45e09a6dac3bdbc6f653e57
Author: Andrei Dulvac <[email protected]>
Date:   2016-04-25T13:42:58Z

    Added rules module

commit 5d44784e3f91acf2e2e244aebf79d87301d18306
Author: Andrei Dulvac <[email protected]>
Date:   2016-04-25T15:13:44Z

    Added readme for http/clients

commit d9582dec918537762ace36a7c5b202b09e1024c3
Author: Andrei Dulvac <[email protected]>
Date:   2016-04-25T15:16:33Z

    @trivial Fixed javadoc link

commit 44b977c65a0fff1928ddc2320c326e5d47bde367
Author: Andrei Dulvac <[email protected]>
Date:   2016-04-28T11:50:35Z

    Removed microdata and HtmlClient + renamed *Quickstart to *Instance

commit acda2659f1766be62a401cf95b2b8357c82a1185
Author: Andrei Dulvac <[email protected]>
Date:   2016-04-28T15:07:25Z

    Added SlingBaseInstanceRule which uses SlingTestBase for now to start an 
instance if needed

commit b7511bc4521f27ce2fbd7279d7c80b1b34fb7b61
Author: Andrei Dulvac <[email protected]>
Date:   2016-04-28T15:08:30Z

    Adapted samples to use http/rules and http/clients

commit 804a5841a2144726e457bfce5030a0da29c3df48
Author: Andrei Dulvac <[email protected]>
Date:   2016-04-28T15:45:53Z

    Moved http/rules to junit/rules and removed 'Base' from rule names

commit 42b2b0ece0b472baf07a2b2bad5f310ababeca3d
Author: Andrei Dulvac <[email protected]>
Date:   2016-04-28T15:46:36Z

    Moved http/rules to junit/rules and removed 'Base' from rule names

commit 6a0eecdd8256f2d8ef460300947d72e4a0b5b420
Author: Andrei Dulvac <[email protected]>
Date:   2016-04-29T07:53:41Z

    Added bundlewit FilterIT test

commit fa2a39f0562d3b6f418ff7f97563872cfd848b5a
Author: Andrei Dulvac <[email protected]>
Date:   2016-04-29T13:08:48Z

    Added clean plugin + rat plugin inclusion for sling/

commit 03fde18f50f718100ab24016f31bdce98c0bb230
Author: Andrei Dulvac <[email protected]>
Date:   2016-04-29T13:11:50Z

    trivial: Changed code comment

----


> Split sling-testing-tools and improve the http clients and junit tooling
> ------------------------------------------------------------------------
>
>                 Key: SLING-5703
>                 URL: https://issues.apache.org/jira/browse/SLING-5703
>             Project: Sling
>          Issue Type: Bug
>          Components: Testing, Tooling
>            Reporter: Andrei Dulvac
>              Labels: sling-testing-tools, testing, testing-http-clients
>
> The sling-testing-tools [0] has become a container for different small pieces 
> of code that don't fit in the other projects under testing/ . What I have 
> identified to be unrelated tools in there are:
> * jarexec + serversetup
> * http clients
> * some junit tooling
> We would like to also contribute some classes that improve the http and junit 
> tooling. The changes are:
> The changes would be the following:
> * leave the tools/ (sling testing tools) untouched, with the idea to 
> eventually deprecate it if the other modules fit the needs.
> * create a new module, called serversetup with the jarexec and serversetup 
> packages copied from sling-testing-tools.
> * create module http/clients with some stuff like the WebconsoleClient copied 
> from tools/ and a bunch of classes that replace the RequestExecutor and 
> client with Threadsafe, well-tested and HttpClient-compatible http tooling.
> * create module junit/rules with junit tooling dependent on the clients which 
> follow the more modern approach to junit rules rather than test base classes 
> and provide ootb rules with clients, junit filtering, configuring references 
> to available sling instances, etc. Both this and clients are designed with 
> extendability  in mind.
> * adapt the "testing/samples" tests to use the junit rules and clients



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to