Now the junit/rules module has the artifact id "org.apache.sling.testing.rules" while all other artifacts in that location have something like "org.apache.sling.junit.*". I think we should consolidate that. Also the packages in the new junit/rules are named "org.apache.sling.testing.junit.rules.*" vs "org.apache.sling.junit.*" in all other junit modules with the exception of teleporter which has the package name in "org.apache.sling.testing.teleporter".
What is the idea with the existing rules in org.apache.sling.junit.rules (in module o.a.s.junit.core)? Should they be moved to the new junit/rules as well? I think that makes sense, but only in case the package names of the latter are adjusted. Konrad > On 29 Apr 2016, at 11:52, Bertrand Delacretaz <[email protected]> wrote: > > Hi Andrei, > > On Fri, Apr 29, 2016 at 10:00 AM, Andrei Dulvac <[email protected]> > wrote: >> ...I took your comments and adapted the two modules, as well as changed the >> samples tests module to use the new clients and rules.... > > Ok thanks! > > I think the http/clients and junit/rules modules are good now apart > from the build issue mentioned in my last message here. > > I agree that the samples/bundle-with-it tests look cleaner with your > variants of the HTTP clients. > > I think TimeoutsProvider would be better in its own > o.a.s.testing.timeouts package. in case we want to split it out later. > > Apart from that IMO you're good to create a jira ticket and patches for this. > > -Bertrand
