[
https://issues.apache.org/jira/browse/SLING-5811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352627#comment-15352627
]
ASF GitHub Bot commented on SLING-5811:
---------------------------------------
GitHub user vladbailescu opened a pull request:
https://github.com/apache/sling/pull/150
SLING-5811 - Properly handle actual Resource's in Sightly data-sly-resource
* Added handling for actual Resource objects in data-sly-resource
* Added tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vladbailescu/sling
SLING-5811_Resource_data-sly-resource
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/sling/pull/150.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #150
----
commit 6ee525fdb6b1fee7ae35003802653e0785ea0eaf
Author: vladbailescu <[email protected]>
Date: 2016-06-28T09:00:42Z
SLING-5811 - Properly handle actual Resource's in Sightly data-sly-resource
* Added handling for actual Resource objects in data-sly-resource
* Added tests
----
> Properly handle actual Resource's in Sightly data-sly-resource
> --------------------------------------------------------------
>
> Key: SLING-5811
> URL: https://issues.apache.org/jira/browse/SLING-5811
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
> Affects Versions: Scripting Sightly Engine 1.0.18
> Reporter: Vlad Bailescu
> Priority: Minor
> Fix For: Scripting Sightly Engine 1.0.20
>
>
> At the moment Sightly {{data-sly-resource}} expects a resource path. The are
> moments where we already have a {{Resource}} that we need to include (such as
> including current resource or iterating and including children) and this
> leads to conversions such as {{Resource -> path -> Resource}} which are not
> desirable performance-wise.
> We should properly handle a resource passed as a parameter, such as:
> {code}<sly data-sly-resource="${resource @ resourceType='some/type'}"/>{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
