[
https://issues.apache.org/jira/browse/SLING-5867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-5867:
-----------------------------------
Description:
Currently {{o.a.s.hc.support.impl.SlingRequestStatusHealthCheck}} just
synchronously calls {{SlingRequestProcessor.processResponse}}.
That means in case of a non-returning response (e.g. caused by a deadlock like
SLING-5847) the health check will just timeout but never actually really fail
(even after a very long time).
In this case it is good to create a dedicated timeout handling within the
{{SlingRequestStatusHealthCheck}} (separate from the timeout in
{{HealthCheckExecutorImpl}}) because for each individual request configuration
you might want to set different timeouts.
was:
Currently {{o.a.s.hc.support.impl.SlingRequestStatusHealthCheck}} just
synchronously calls {{SlingRequestProcessor.processResponse}}.
That means in case of a non-returning response (e.g. caused by a deadlock like
SLING-5847) the health check will just timeout but never actually really fail
(even after a very long time).
In this case it is good to create a dedicated timeout handling (separate from
the timeout in {{HealthCheckExecutorImpl}}) because for each individual request
configuration you might want to set different timeouts.
> SlingRequestStatusHealthCheck should add timeout support
> --------------------------------------------------------
>
> Key: SLING-5867
> URL: https://issues.apache.org/jira/browse/SLING-5867
> Project: Sling
> Issue Type: Bug
> Components: Health Check
> Affects Versions: Health Check Support 1.0.4
> Reporter: Konrad Windszus
>
> Currently {{o.a.s.hc.support.impl.SlingRequestStatusHealthCheck}} just
> synchronously calls {{SlingRequestProcessor.processResponse}}.
> That means in case of a non-returning response (e.g. caused by a deadlock
> like SLING-5847) the health check will just timeout but never actually really
> fail (even after a very long time).
> In this case it is good to create a dedicated timeout handling within the
> {{SlingRequestStatusHealthCheck}} (separate from the timeout in
> {{HealthCheckExecutorImpl}}) because for each individual request
> configuration you might want to set different timeouts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
