[ 
https://issues.apache.org/jira/browse/SLING-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15395800#comment-15395800
 ] 

Tommaso Teofili commented on SLING-5730:
----------------------------------------

thanks [~simone.tripodi], the patch is very nice. Just a little thing: I was 
wondering if we could basically rewrite the {{FileBackedOutputStream}} class to 
suite our needs of:
 - controlling where files are created
 - dump them more often than just 
["onExit"|https://github.com/google/guava/blob/master/guava/src/com/google/common/io/FileBackedOutputStream.java#L200]
 .

That way we also avoid introducing the dependency to Guava for just one class.
Thanks a lot for your contributions!

> Avoid creating a File of a package when it's small enough to fit in memory
> --------------------------------------------------------------------------
>
>                 Key: SLING-5730
>                 URL: https://issues.apache.org/jira/browse/SLING-5730
>             Project: Sling
>          Issue Type: Improvement
>          Components: Distribution
>            Reporter: Tommaso Teofili
>            Assignee: Simone Tripodi
>         Attachments: SLING-5730.1.patch, SLING-5730.patch
>
>
> {{ResourcePackageBuilder}} creates a temporary file holding the actual 
> package stream, it'd be good to avoid that when the size of the stream is 
> small enough to quickly fit into memory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to