[ 
https://issues.apache.org/jira/browse/SLING-5913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Simone Tripodi updated SLING-5913:
----------------------------------
    Attachment: SLING-5913.2.patch

hi again [~teofili],
sorry for bugging but I am providing a last patch which fixes also test cases 
best practices, dropping _foreach_ statements for multiple tests in favour of 
data providers, replacing {{try {} catch(MyException e) { fail(e) } }} code 
blocks for the more canonical {{@Test(expected = MyException.class)}} 
declaration.
HTH!

> Clean-up the Distribution Core source code
> ------------------------------------------
>
>                 Key: SLING-5913
>                 URL: https://issues.apache.org/jira/browse/SLING-5913
>             Project: Sling
>          Issue Type: Improvement
>          Components: Distribution
>    Affects Versions: Content Distribution Core 0.1.18
>            Reporter: Simone Tripodi
>            Assignee: Tommaso Teofili
>            Priority: Minor
>             Fix For: Content Distribution 0.2.0
>
>         Attachments: SLING-5913.1.patch, SLING-5913.2.patch, SLING-5913.patch
>
>
> Current codebase is full of warnings due to unbound generics type, not used 
> variables, ... that makes code reading less pleasant than expected



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to