On Thu, 2016-07-28 at 11:31 +0200, Oliver Lietz wrote:
> On Monday 25 July 2016 15:02:33 Robert Munteanu wrote:
> [...]
> >
> > Looks good, thank you! If I get one more nitpick :-) it would be
> > asking
> > to include the oak-segment bundle declaration in the method that
> > configures it ( slingLaunchpadOakTarConfiguration ). If I invoke
> > that
> > method it's clear that I want the oak-segment bundle included as
> > well.
>
> SLING-5893:
>
> protected Option launchpad() {
> final int httpPort = findFreePort();
> final String workingDirectory = workingDirectory();
> return composite(
> slingLaunchpadOakTar(workingDirectory, httpPort),
> slingExtensionI18n(),
> slingExtensionModels(),
> slingScriptingJsp()
> );
> }
>
Looks good, thanks for adding these!
Robert
>
> >
> > I've also filed a couple of enhancement requests based on what I
> > have
> > seen in other modules - basically boilerplate we copy/paste between
> > @Configuration methods.
>
> See my comments in these issues.
>
> >
> > Other than that, it's not 100% clear to me why, but it seems that
> > there
> > isn't a 'good' Servlet API bundle included in the current
> > SlingOptions
> > class. There is the geronimo specs Jar, but IIUC it's for version
> > 3.0
> > only and we use 3.1 already in some place.
> >
> > I've solved this by adding
> >
> >
> > mavenBundle().groupId("org.apache.felix").artifactId("org.apache.fe
> > li
> > x.http.servlet-api").version("1.1.2")
> >
> > to the build.
>
> See r1753994 and r1754021.
>
> Thanks for feedback, Robert. Much appreciated!
>
> Regards,
> O.
>
> >
> > Thanks,
> >
> > Robert
>
