Hi,

On 16/08/16 13:51, "Stefan Egli" <[email protected]> wrote:

>>2) Does the metrics library by default make all values available via
>>JMX as well?
>
>That I don't know, couldn't find it at least.

FYI: due to SLING-5424 (jmxReporter not started) this indeed doesn't work
in commons.metrics-1.0.0 yet, only in 1.0.2 (not yet released). Albeit
with an empty (JMX) 'Type' - which seems to be due to [1] not using a
custom ObjectNameFactory as [0] does. So perhaps we should also use such a
factory for commons metrics?

Cheers,
Stefan
--
[0] 
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/
org/apache/jackrabbit/oak/plugins/metric/MetricStatisticsProvider.java#L77
[1] 
https://github.com/apache/sling/blob/trunk/bundles/commons/metrics/src/main
/java/org/apache/sling/commons/metrics/internal/MetricsServiceImpl.java#L21
5


Reply via email to